fix: gitlint installation #616
Merged
+8
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Latest ubuntu does not allow system wide pip install. It can be overriden with `--break-system-packages`, but it's better to create a virtual env. Note: This came up in another repo where we use ubuntu-latest. Here were using an older version of ubuntu, but we it's probably best we switch to ubuntu-latest as well. Signed-off-by: Martin Malina <[email protected]>
johnbieren
approved these changes
Oct 16, 2024
There was a problem hiding this comment.
Ah, I think the reason we had 20.04 instead of latest was to avoid exactly what happened - a new update to the image which breaks us without us changing anything. It isn't great to be on old images though, so maybe latest is just better and we address issues as they pop up 🤷♂️
Yeah, agreed, it's a tradeoff and latest is probably better in this case - it's just CI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Latest ubuntu does not allow system wide pip install. It can be overriden with
--break-system-packages, but it's better to create a virtual env.Note: This came up in another repo where we use ubuntu-latest. Here were using an older version of ubuntu, but we it's probably best we switch to ubuntu-latest as well.